Re: [PATCH] mailbox: qcom-ipcc: remove stray disable_irq_wake() call

[Jassi Brar]

On Wed, Sep 16, 2026 at 2:31 AM Anup Vishwakarma
<anup.vishwakarma@xxxxxxxxxxxxxxxx> wrote:
>
> Commit afaf2ba5b430 ("mailbox: qcom-ipcc: Support interrupt wake up
> from suspend") replaced enable_irq_wake() with IRQF_NO_SUSPEND on the
> IRQ request, but left the paired disable_irq_wake() in remove()
> behind.
>
> disable_irq_wake() decrements the IRQ's wake_depth. With no matching
> enable_irq_wake() left to increment it, wake_depth stays at 0 and
> irq_set_irq_wake() reports:
>
>   WARN(1, "Unbalanced IRQ %d wake disable\n", irq)
>
> on every unbind. Since there is no enable_irq_wake() to pair it with,
> remove the stray disable_irq_wake() call; IRQF_NO_SUSPEND already
> provides the intended wake behaviour.
>
> Fixes: afaf2ba5b430 ("mailbox: qcom-ipcc: Support interrupt wake up from suspend")
> Signed-off-by: Anup Vishwakarma <anup.vishwakarma@xxxxxxxxxxxxxxxx>
> ---
>  drivers/mailbox/qcom-ipcc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
> index 185b63f724d4..759577055671 100644
> --- a/drivers/mailbox/qcom-ipcc.c
> +++ b/drivers/mailbox/qcom-ipcc.c
> @@ -348,7 +348,6 @@ static void qcom_ipcc_remove(struct platform_device *pdev)
>  {
>         struct qcom_ipcc *ipcc = platform_get_drvdata(pdev);
>
> -       disable_irq_wake(ipcc->irq);
>         irq_domain_remove(ipcc->irq_domain);
>  }
>
>
> ---
> base-commit: e6e35979777d646fe3c7c94dca7dd32fb25d45f4
> change-id: 20260916-b4-ipcc_wake_disable_upstream-28bcbd84cef4
>
> Best regards,
> --
> Anup Vishwakarma <anup.vishwakarma@xxxxxxxxxxxxxxxx>
>
Applied to mailbox/for-next

Thanks
Jassi