Re: [PATCH v3 2/4] ntfs: add pathname access for named streams

[Namjae Jeon]

On Mon, Oct 12, 2026 at 10:27 AM CharSyam <charsyam@xxxxxxxxx> wrote:
>
> Hi, Namjae.
>
> I noticed a remount issue with streams_interface. During
> reconfiguration, fc->s_fs_info points to a newly allocated
> ntfs_volume, rather than
>   the mounted volume. Consequently, remounting with the existing
> windows setting fails, while requesting none succeeds without changing
> the
>   active setting.
>
>   The check should use the mounted volume:
>
>   diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
>   @@ -275,8 +275,8 @@ static int ntfs_parse_param(struct fs_context
> *fc, struct fs_parameter *param)
>                         result.uint_32 == STREAMS_INTERFACE_WINDOWS;
>
>                 if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE &&
>   -                 NVolStreamsWindows(vol) != streams_windows) {
>   -                     ntfs_error(vol->sb,
>   +                 NVolStreamsWindows(NTFS_SB(fc->root->d_sb)) !=
> streams_windows) {
>   +                     ntfs_error(fc->root->d_sb,
>                                    "Cannot change streams_interface on
> remount.");
>                         return -EINVAL;
>                 }
>
>   Since pathname support is already committed to ntfs-next, I will
> send this as a separate follow-up patch.
Okay. You can send it.
Thanks for the review.