Re: [PATCH v8 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

[Harendra Gautam]

> > +
> > +  reg:
> > +    maxItems: 1
> > +    description: QAIF core registers
>
> Drop the description.
Will drop in the next version.

> > +
> > +  iommus:
> > +    maxItems: 1
> > +    description: Phandle to apps_smmu node with sid mask
>
> Drop. The exact provider is outside the scope of this binding.
Will drop in the next version.

> > +      dai-tdm-slot-tx-mask:
> > +        $ref: /schemas/types.yaml#/definitions/uint32-array
>
> These are all common properties. Don't redefine the type. You need to
> reference the common schema (at the object/node level, not per
> property).
Will update in the next version.


> > +
> > +      qcom,qaif-aif-lane-map:
> > +        $ref: /schemas/types.yaml#/definitions/uint32-array
> > +        description:
> > +          Per-lane direction map, one entry per lane starting from lane 0.
> > +          Use 0 for TX (output/speaker) and 1 for RX (input/mic).
> > +        minItems: 1
> > +        maxItems: 8
> > +        items:
> > +          enum: [0, 1]
>
> Can't you use a single uint32 bit mask for this?
Here intention to keep this consistent with the other tdm mask array properties.
-Harendra
>
> Rob