Re: [PATCH v6 00/18] mtd: rawnand: sunxi: support the Allwinner randomized OOB format
From: Miquel Raynal
Date: Mon Oct 12 2026 - 04:07:12 EST
Hi James,
On 14/09/2026 at 15:09:46 -06, James Hilliard <james.hilliard1@xxxxxxxxx> wrote:
> Allwinner NAND firmware leaves the bad-block marker in the randomizer
> data stream. On H6/H616 it also places all protected user data before the
> first ECC step. These choices differ from the mainline format, which
> keeps the physical marker plain and maximizes the H6/H616 user-data area.
[...]
> Assisted-by: Codex:gpt-6-astra
> Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx>
> ---
I am sorry but I do not want to proceed further with this series.
Even though I am not capable of finger pointing what is wrong in the
diffs nor in the commit logs, I do not understand most of it. I cannot
clearly explain why, but I have had a hard time trying to understand
what the commits were doing. The risk is that nobody would then be able
to further maintain this driver and I am not willing to take that
option. The kernel policy so far has been to ensure readability and
maintainability, and my gut feeling is that this series is going
sideways wrt this major constraint.
Also, from a Linux kernel point of view, we generally just do not
support vendor specific layouts. I already told so Richard Genoud back
when he was working on H616.
With this added to the pile, I prefer not to merge the entire series. I
can still take some of the fixes if you feel like they would be relevant
anyway. In which case I invite you to send a v7 with just the few fixes
you think are actually relevant outside of the randomized layout
support.
Thank you for your understanding,
Miquèl