Re: [PATCH iwl-net] ice: do not report success for a VF setting that was not applied

[Linkui Xiao]

On 2026/10/12 16:34, netdev-bot+sinfo@xxxxxxxxxx wrote:
> Hi!
>
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
>
>   - What hardware the change was tested on. For driver fixes please
>     mention the device (and if relevant firmware version) used for
>     testing, or say that the change was not tested on real hardware.
>
> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
>
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.

Hi,
Thanks for the note. The automated check is correct; the commit message is
missing the hardware-testing information. Here it is.

This change was not tested on real hardware, and there is no Tested-by tag
for exactly that reason. The race was found by code inspection of the ndo VF
handlers; it was not reproduced at runtime.

What I verified is limited to build and static checks:

- ice_sriov.o was build tested only, with the native kbuild command line of
  an existing v7.3-rc2 x86_64 build tree (gcc 9.3.0), both with the normal
  -Wall set and with -Wextra added. The diagnostics for the baseline file
  and for the patched file are identical (zero), so the patch adds no new
  warnings. The only new undefined symbol in the object is
  ice_is_vf_disabled(), the helper the patch starts calling.
- checkpatch.pl --strict: 0 errors, 0 warnings, 0 checks.
- The patch applies to e04de0215596 with no offset, and at the object level
  only __ice_set_vf_mac(), ice_set_vf_trust() and ice_set_vf_port_vlan()
  gain an ice_is_vf_disabled() call; no other function in the file is
  affected.

I could not run it on hardware: reaching the window needs an ice PF with
SR-IOV enabled and VFs assigned, plus a PF-wide VF reset racing with a VF
configuration request. The reset side is the ice_reset_all_vfs() path, i.e.
a PF-wide reset: a PFR (ethtool --reset <pf> pfr is one way to ask for one)
or a CORER/GLOBR/EMPR completion. The other side is an
"ip link set dev <pf> vf <n> mac|trust|vlan ..." request. I do not have
access to such a system.

For anyone who does have one: on the unpatched baseline the visible symptom
is that "ip link show <pf>" and the VF's devlink port report the new setting
while the hardware and the switch keep using the old one. With the patch the
request should come back with -EINVAL instead of reporting success. I am
happy to run any specific test that is suggested.

No repost was made, as requested. If a v2 is needed for other reasons, I'll
include this information in the commit messages.

Thanks,
Linkui