Re: [PATCH v2 1/2] regulator: dt-bindings: add hi3798cv200 regulator

[Krzysztof Kozlowski]

On Sat, Oct 10, 2026 at 05:43:39AM +0800, David Yang wrote:
> The PMOC block of the HiSilicon STB SoCs (Hi3798cv200/mv100/mv200)
> drives an external converter with a PWM signal. Add dt-binding doc.
> 
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>
> ---
>  .../hisilicon,hi3798cv200-regulator.yaml      | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi3798cv200-regulator.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi3798cv200-regulator.yaml b/Documentation/devicetree/bindings/regulator/hisilicon,hi3798cv200-regulator.yaml
> new file mode 100644
> index 000000000000..812d94aca1f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi3798cv200-regulator.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/hisilicon,hi3798cv200-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon STB voltage regulator
> +
> +maintainers:
> +  - David Yang <mmyangfl@xxxxxxxxx>
> +
> +description: |
> +  HiSilicon STB SoCs (Hi3798cv200/mv100/mv200) provide PWM outputs in the PMOC
> +  block which drive an external converter.

SoCs rarely provide supplies for themselves (they are rather called
power domains in such case) and above wording suggests this is actually
something external. It also speaks about PWM but binding has no PWM.

> +
> +  The voltage range depends on the board design: reference designs specify
> +  0.65 V to 1.15 V for the Hi3798cv200, and 0.7 V to 1.25 V for the Hi3798mv200;
> +  a customized board has to figure out its own. The regulator itself has no
> +  other source of calibration.
> +
> +properties:
> +  compatible:
> +    const: hisilicon,hi3798cv200-regulator
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - regulator-min-microvolt
> +  - regulator-max-microvolt
> +
> +allOf:
> +  - $ref: regulator.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    vddcpu: regulator@8a23018 {

Drop unused label

> +        compatible = "hisilicon,hi3798cv200-regulator";
> +        reg = <0x8a23018 0x4>;

And one word is rarely a device, which adds to the confusion.

Best regards,
Krzysztof