[PATCH v4] usb: hub: Set proper message when usb_hub_create_port_device() fails
From: Chen-Yu Tsai
Date: Mon Oct 12 2026 - 05:32:11 EST
Right now when usb_hub_create_port_device() fails, it prints a separate
error message to say which port failed, but otherwise leaves |message|
set to the default "out of memory", which is somewhat misleading.
Set |message| to an error message that is more specific to this error
path instead of using the default "out of memory" message.
Assisted-by: LLM # local reviews
Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
---
Changes since v3:
- Print custom error message directly and use generic error message for
later, instead of using more stack space
Changes since v2:
- Simplify to just using a small buffer on the stack (Alan)
Changes since v1:
- Explicitly track and free the allocated custom error message instead
of using devm_kasprintf()
- Link to v1:
https://lore.kernel.org/all/20260728100005.413868-1-wenst@xxxxxxxxxxxx/
Sorry Andy, I ended up not using your __free(kfree_const) patch. My LLM
was telling me that it won't work correctly if CONFIG_USB=m.
---
drivers/usb/core/hub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 0e929a4c9fa1..4c85fdf7a233 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1758,6 +1758,7 @@ static int hub_configure(struct usb_hub *hub,
if (ret < 0) {
dev_err(hub->intfdev,
"couldn't create port%d device.\n", i + 1);
+ message = "couldn't create port device";
break;
}
}
--
2.56.0.385.gd3acb90ef8-goog