Re: [PATCH v18 12/13] dt-bindings: mediatek: Add MT8196 JPEG SMMU bindings

[Krzysztof Kozlowski]

On Sat, Oct 10, 2026 at 04:07:16PM +0800, Kyrie Wu wrote:
> Document the decoder and encoder phandles and describe the dedicated
> JPEG SMMU configuration syscon for MT8196.
> 
> Signed-off-by: Kyrie Wu <kyrie.wu@xxxxxxxxxxxx>
> ---
>  .../media/mediatek,mt8195-jpegdec.yaml        | 16 ++++++++
>  .../media/mediatek,mt8195-jpegenc.yaml        | 16 ++++++++
>  .../mediatek/mediatek,mt8196-jpeg-smmu.yaml   | 41 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +
>  4 files changed, 75 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,mt8196-jpeg-smmu.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> index 28a9a9b..b1dccc3 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> @@ -73,6 +73,22 @@ patternProperties:
>        power-domains:
>          maxItems: 1
>  
> +      mediatek,smmu-config:
> +        $ref: /schemas/types.yaml#/definitions/phandle
> +        description:
> +          Phandle to the MT8196 JPEG SMMU configuration syscon used to
> +          program this decoder's GUSER_ID fields.
> +
> +    allOf:
> +      - if:
> +          properties:
> +            compatible:
> +              contains:
> +                const: mediatek,mt8196-jpgdec-hw
> +        then:
> +          required:
> +            - mediatek,smmu-config

Why are you adding incomplete hardware in one patch and then immediately
fixing it later?

Please read writing bindings doc (and part about complete hardware
support).

Best regards,
Krzysztof