Re: [PATCH 2/2] lib/crc: loongarch: Add 3-way parallel CRC32(C) for large buffers

[Huacai Chen]

On Mon, Oct 12, 2026 at 3:24 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Mon, Oct 12, 2026 at 02:45:24PM +0800, Huacai Chen wrote:
> > Yes, crc_kunit is passed.
>
> Are you sure?  This patch reads 4096 bytes from a 4-byte buffer, which
> seems a bit problematic.
Yes, I'm sure --- but that doesn't mean I'm correct, probably because
there is a large block with 0.

Our old version used crc32_le_shift() and __crc32c_le_shift(), but
they are removed now. So we did the same change as commit
b6ccde39b1c1292ad44 ("gfs2: avoid inefficient use of
crc32_le_shift()"), but forgot to increase the zero buffer from 4 to
4096.

Huacai

>
> - Eric