Re: [PATCH] isofs: Fix handling of directories with small logical blocks

[Thomas Schmitt]

Hi,

Hengyu Liang wrote:
> As far as I can see, the option sets the size of the buffer that is
> read, but not the place. The loop over the volume descriptors has
> 
>         block = iso_blknum << (ISOFS_BLOCK_BITS - s->s_blocksize_bits);

I see. The code of fs/isofs surprises me every time i look at it.


> I think 2048 is the right value for the check.

I now agree.

(Actually i think 2048 is the only right value for Sector and Block.
Everything else is just weird.
libisofs did not check Logical Block Size at all. Yesterday i committed
"Prevented reading of filesystems with logical block size != 2048".)


Have a nice day :)

Thomas