Re: [PATCH v6 09/13] gpio: mxc: use cleanup guard for pm_runtime_get_noresume() balance

[Andy Shevchenko]

On Mon, Oct 12, 2026 at 1:06 PM Peng Fan <peng.fan@xxxxxxxxxxx> wrote:
> On Mon, Oct 12, 2026 at 12:38:37PM +0300, Andy Shevchenko wrote:
> >On Sun, Oct 11, 2026 at 2:54 PM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:


...

> >> +DEFINE_FREE(pm_runtime_put_noidle, struct device *, if (_T) pm_runtime_put_noidle(_T))
> >
> >Please, split this to a separate patch and move it directly to pm_runtime.h.
>
> Frank raised same suggestion in V5.
>
> I tend to avoid introducing cross-subsystem dependency and use a follow-up
> patch to move it to pm_runtime.h

Alternatively you may not use it, just carefully put a goto:s and error labels.

> But since you both vote for pm_runtime.h, let me separate it in V7.

Also think about splitting the series to three. Do not rush! It anyway
missed v7.4 (except, perhaps, the first fixes part).

-- 
With Best Regards,
Andy Shevchenko