Re: [PATCH v2 2/2] Input: aw8697 - Add Awinic AW8697 haptics driver

[Uwe Kleine-König]

On Wed, Sep 30, 2026 at 07:18:51PM +0200, Armandas Kvietkus via B4 Relay wrote:
> +#include <linux/mod_devicetable.h>

You can (and should) rely on <linux/i2c.h> to provide i2c_device_id and
of_device_id. Please don't use <linux/mod_devicetable.h> which mostly
only adds unneeded build dependencies.

> +static const struct i2c_device_id aw8697_id[] = {
> +	{ "aw8697" },

Please use a named initializer, i.e.:

	{ .name = "aw8697" },

> +	{ }
> +};

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature