Re: [PATCH v11 3/6] platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries

From: Ilpo Järvinen

Date: Mon Oct 12 2026 - 08:27:18 EST


On Mon, 12 Oct 2026, Mingyou Chen wrote:

> Add the missing Redmibook mic-mute hotkey definitions to the shared
> sparse keymap table:
> - 0x00002101 (Fn-lock disabled state)
> - 0x00012101 (Fn-lock enabled state)
>
> Reported-by: Nika Krasnova <nika@xxxxxxxxxxxx>
> Link:
> https://lore.kernel.org/platform-driver-x86/20260531123345.237521-1-nika@xxxxxxxxxxxx/
> Signed-off-by: Mingyou Chen <qby140326@xxxxxxxxx>
> ---
> drivers/platform/x86/bitland-mifs-wmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/bitland-mifs-wmi.c b/drivers/platform/x86/bitland-mifs-wmi.c
> index a6978d14b975..93a519b96189 100644
> --- a/drivers/platform/x86/bitland-mifs-wmi.c
> +++ b/drivers/platform/x86/bitland-mifs-wmi.c
> @@ -636,6 +636,10 @@ static const struct key_entry bitland_mifs_wmi_keymap[] = {
> { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_SWITCHVIDEOMODE, 1, 0), { KEY_SWITCHVIDEOMODE } },
> { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_REFRESH_RATE, 0, 0), { KEY_REFRESH_RATE_TOGGLE } },
>
> + /* Mic-mute key */
> + { KE_KEY, BI_HOTKEY_CODE(0x21, 0, 0), { KEY_MICMUTE } },
> + { KE_KEY, BI_HOTKEY_CODE(0x21, 1, 0), { KEY_MICMUTE } },
> +
> /* AI button has code for each position */
> { KE_KEY, BI_HOTKEY_CODE(WMI_EVENT_FN_5, 1, 0), { KEY_ASSISTANT } },
>
>

What about this comment:

https://lore.kernel.org/all/20261008152651.1510220-1-uselessfire@xxxxxxxxx/

--
i.