[PATCH 2/2] soc: qcom: geni-se: Avoid redundant transfer mode selection
From: Viken Dadhaniya
Date: Mon Oct 12 2026 - 08:35:03 EST
geni_se_select_mode() is called for every FIFO and SE-DMA transfer, even
when the serial engine is already configured for the requested mode. Each
call clears interrupt status and accesses mode-related registers, causing
unnecessary MMIO operations on the transfer path.
Cache the previously selected mode and skip only redundant mode
programming. Preserve pending interrupt status cleanup and GPI event
routing. Invalidate the cache from geni_se_init(). Update it only after a
valid mode selection.
Signed-off-by: Viken Dadhaniya <viken.dadhaniya@xxxxxxxxxxxxxxxx>
---
drivers/soc/qcom/qcom-geni-se.c | 11 ++++++++++-
include/linux/soc/qcom/geni-se.h | 1 +
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
index 311046544b4c..ce4de4917a83 100644
--- a/drivers/soc/qcom/qcom-geni-se.c
+++ b/drivers/soc/qcom/qcom-geni-se.c
@@ -370,6 +370,8 @@ void geni_se_init(struct geni_se *se, u32 rx_wm, u32 rx_rfr)
{
u32 val;
+ se->prev_xfer_mode = GENI_SE_INVALID;
+
geni_se_irq_clear(se);
geni_se_io_init(se->base);
geni_se_io_set_mode(se->base);
@@ -462,6 +464,11 @@ void geni_se_select_mode(struct geni_se *se, enum geni_se_xfer_mode mode)
{
WARN_ON(mode != GENI_SE_FIFO && mode != GENI_SE_DMA && mode != GENI_GPI_DMA);
+ if (likely(se->prev_xfer_mode == mode)) {
+ geni_se_clear_irq_status(se);
+ return;
+ }
+
switch (mode) {
case GENI_SE_FIFO:
geni_se_select_fifo_mode(se);
@@ -474,8 +481,10 @@ void geni_se_select_mode(struct geni_se *se, enum geni_se_xfer_mode mode)
break;
case GENI_SE_INVALID:
default:
- break;
+ return;
}
+
+ se->prev_xfer_mode = mode;
}
EXPORT_SYMBOL_GPL(geni_se_select_mode);
diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni-se.h
index b3372a3147a0..f77c3a47c3d0 100644
--- a/include/linux/soc/qcom/geni-se.h
+++ b/include/linux/soc/qcom/geni-se.h
@@ -78,6 +78,7 @@ struct geni_se {
struct geni_icc_path icc_paths[3];
struct dev_pm_domain_list *pd_list;
bool has_opp;
+ enum geni_se_xfer_mode prev_xfer_mode;
};
/* Common SE registers */
--
2.34.1