Re: [PATCH v2 3/6] iio: imu: Add driver for the ADI ADIS16607

[Uwe Kleine-König]

On Thu, Oct 08, 2026 at 11:31:55AM +0300, Radu Sabau via B4 Relay wrote:
> +#include <linux/mod_devicetable.h>

Please drop this header. <linux/spi/spi.h> already provides the needed
*_device_id structs.

> +static const struct spi_device_id adis16607_id[] = {
> +	{ "adis16607-2", (kernel_ulong_t)&adis16607_2_chip_info },
> +	{ "adis16607-3", (kernel_ulong_t)&adis16607_3_chip_info },

Please use named initializers here (i.e.

	{ .name = "adis16607-2", .driver_data = (kernel_ulong_t)&adis16607_2_chip_info },
	...

)

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature