Re: [PATCH v2] power: sequencing: qcom-wcn: power off WLAN at probe
From: Bartosz Golaszewski
Date: Mon Oct 12 2026 - 10:05:37 EST
On Sun, 04 Oct 2026 18:51:24 +0200, François Roux wrote:
> The WLAN enable GPIO is requested with GPIOD_ASIS and then kept at its
> current level, so that a WLAN module left powered on by the firmware is
> not switched off. The FIXME explains why: toggling it would take the
> PCIe link down, and the controller driver could not recover from that.
>
> That reasoning held while the PCIe link was trained before the
> sequencer probed. Since commit b921aa3f8dec ("PCI/pwrctrl: Switch to
> pwrctrl create, power on/off, destroy APIs"), qcom_pcie_host_init()
> powers the endpoint through pwrctrl before it starts link training, and
> defers until the pwrctrl driver is bound. That driver cannot bind
> before this sequencer has probed. Power-on therefore always comes
> before link training, and keeping the firmware state is now harmful.
>
> [...]
Applied, thanks!
[1/1] power: sequencing: qcom-wcn: power off WLAN at probe
https://git.kernel.org/brgl/c/dbd674ccf30f66f5eccf637964a93910df8dbf84
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>