Re: [PATCH] accessibility: speakup: Use isdigit() in handle_goto()

[Samuel Thibault]

Thorsten Blum, le lun. 12 oct. 2026 15:08:05 +0200, a ecrit:
> Use isdigit() to replace the open-coded implementation.
> 
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>

Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Thanks!

> ---
>  drivers/accessibility/speakup/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
> index e9b7c2761f6f..a7c14531f2ce 100644
> --- a/drivers/accessibility/speakup/main.c
> +++ b/drivers/accessibility/speakup/main.c
> @@ -1980,7 +1980,7 @@ static int handle_goto(struct vc_data *vc, u_char type, u_char ch, u16 key)
>  	maxlen = (*goto_buf >= '0') ? 3 : 4;
>  	if ((ch == '+' || ch == '-') && num == 1)
>  		return 1;
> -	if (ch >= '0' && ch <= '9' && num < maxlen)
> +	if (isdigit(ch) && num < maxlen)
>  		return 1;
>  	if (num < maxlen - 1 || num > maxlen)
>  		goto oops;
>