Re: [PATCH] staging: iio: addac: adt7316: use dev_err_probe() for ldac GPIO

[Nuno Sá]

On Sun, Oct 11, 2026 at 07:56:22PM +0100, Raffaele Tranfaglia via B4 Relay wrote:
> From: Raffaele Tranfaglia <raffaele.tranfaglia@xxxxxxxxx>
> 
> Use dev_err_probe() when requesting the ldac GPIO fails. This
> avoids logging an error when the GPIO controller is not ready yet
> and the request returns -EPROBE_DEFER, and records the deferral
> reason. It also simplifies the error path.
> 
> Signed-off-by: Raffaele Tranfaglia <raffaele.tranfaglia@xxxxxxxxx>
> ---
> Compile-tested only.
> ---

Not sure what's Jonathan policy in here (or don't remember :)).
Personally, I don't see much benefit on this kind of patches. I'm aware
you might be eager to have something upstream but for staging I guess
the real value is in having someone willing to really cleanup the driver
so that we can take it out of staging (naturally that also means having
HW or someone willing to test it).

- Nuno Sá

>  drivers/staging/iio/addac/adt7316.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 20f6052cc7fb..8ca6def84584 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -2142,11 +2142,9 @@ int adt7316_probe(struct device *dev, struct adt7316_bus *bus,
>  
>  	chip->ldac_pin = devm_gpiod_get_optional(dev, "adi,ldac",
>  						 GPIOD_OUT_LOW);
> -	if (IS_ERR(chip->ldac_pin)) {
> -		ret = PTR_ERR(chip->ldac_pin);
> -		dev_err(dev, "Failed to request ldac GPIO: %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(chip->ldac_pin))
> +		return dev_err_probe(dev, PTR_ERR(chip->ldac_pin),
> +				     "Failed to request ldac GPIO\n");
>  
>  	if (!chip->ldac_pin) {
>  		chip->config3 |= ADT7316_DA_EN_VIA_DAC_LDAC;
> 
> ---
> base-commit: a22dc7ebb21a6bd4c8b63bc2c1dd46a24945aae7
> change-id: 20261011-adt7316-dev-err-probe-8ffb5e224100
> 
> Best regards,
> --  
> Raffaele Tranfaglia <raffaele.tranfaglia@xxxxxxxxx>
> 
>