Re: [PATCH] sched/eevdf: Fix vprot across reweighting
From: Kayra Cizmeci
Date: Mon Oct 12 2026 - 11:14:03 EST
I send one mail, one more to reply comes. Ah.. I love it tho :-)
> Before 819224e506bc ("sched/fair: Remove dead code on
> enqueue_task_fair()"), the reweight_eevdf() was not called for curr so
> the false was always true. If we can finally have enqueue curr then we
> should skip this case
Yeah. The beast I created kills me. Pretty nice.
On sched_change_begin(), cfs_rq->curr is set to NULL. So while entering enqueue_task_fair(), curr is false.
on_rq is false too. But the tasks weight is changed and vprot never gets touched so it got wrong. Then on set_next_task_fair(),
the task is curr again.