Re: [PATCH v2 2/2] arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Tab S9 Wi-Fi

[Konrad Dybcio]

On 10/5/26 9:47 PM, Nizat Mikayilli via B4 Relay wrote:
> From: Nizat Mikayilli <nacht@xxxxxxxxxx>
> 
> Add support for the Samsung Galaxy Tab S9 Wi-Fi (SM-X710, codename
> gts9wifi) tablet, based on the SM8550 SoC. This is the Wi-Fi SKU, so the
> modem memory regions are removed and no modem firmware is referenced.
> 
> Described hardware: UFS storage, the microSD slot, USB 2.0 peripheral
> mode over the eUSB2 PHY with an NXP PTN3222 repeater, the
> bootloader-provided framebuffer console, power and volume keys, the
> book-cover switch, GPU, video decoder, ADSP with the internal audio path
> (four CS35L45 speaker amplifiers and the VA-macro digital microphones).
> 
> Tested on hardware: booted via U-Boot on top of linux-next
> next-20261002, with the default kernel command line (no
> clk_ignore_unused, pd_ignore_unused or regulator_ignore_unused).
> Verified: UFS storage enumeration, USB 2.0 gadget, framebuffer console,
> power and volume keys, the book-cover switch, CPU frequency scaling, GPU
> (firmware loads, render node present), video decoder (device opens),
> ADSP booting at startup with the sound card registered and all four
> amplifiers and the VA macro probing. The microSD slot is described but
> not yet tested; audio playback and capture were not exercised.

Please test them!

> The display panel, touch, pen digitizer, cameras, battery/charging and
> the wireless module are not described here; the latter needs additional
> power sequencing and follows as a separate series.

Wi-Fi/BT should be a low-hanging fruit, see e.g. sm8550-qrd.dts

[...]

> +&i2c6 {
> +	clock-frequency = <400000>;
> +	status = "okay";

nit: let's keep a \n before 'status', file-wide

[...]

> +&tlmm {
> +	/* GPIO36..39 are owned by TrustZone. */

Do we have an idea as to what they're connected to?

[...]

> +/* Without a Type-C controller driver, keep the DWC3 in peripheral mode. */

Is there no pmic-glink in the firmware?

Konrad