Re: [PATCH 7/7] mailbox: goog-mba: Introduce the goog-mba mailbox driver

[Doug Anderson]

Hi,

On Sat, Oct 10, 2026 at 3:15 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> …
> > +++ b/drivers/mailbox/goog-mba.c
> > @@ -0,0 +1,567 @@
> …
> > +static int goog_mba_send_data(struct mbox_chan *chan, void *msg)
> > +{
> …
> > +             spin_lock_irqsave(&goog_mbox->lock, flags);
> > +             out_of_space = payload_words &&
> > +                            (goog_mbox->outstanding_msgs >=
> > +                             goog_mbox->msg_buffer_words / payload_words);
> > +             spin_unlock_irqrestore(&goog_mbox->lock, flags);
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&goog_mbox->lock);”?
> https://elixir.bootlin.com/linux/v7.3-rc6/source/include/linux/spinlock.h#L642-L645

Sure. Once everything is resolved and I'm ready to send out a v2, I'll
make sure to include that change.

-Doug