Re: [PATCH] platform/x86: thinkpad_acpi: fix deadlock in hotkey input open/close

From: Ilpo Järvinen

Date: Mon Oct 12 2026 - 12:15:44 EST


On Fri, 09 Oct 2026 20:18:24 -0700, Dmitry Torokhov wrote:

> Commit d6479c25ecef ("platform/x86: thinkpad_acpi: Use
> input_device_enabled()") changed hotkey_poll_setup() to acquire
> tpacpi_inputdev->mutex and call input_device_enabled(tpacpi_inputdev).
>
> However, the input core already holds dev->mutex when invoking a
> device's open() and close() callbacks. Because hotkey_inputdev_open()
> and hotkey_inputdev_close() call into hotkey_poll_setup(), attempting to
> acquire tpacpi_inputdev->mutex again results in an immediate
> self-deadlock.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: fix deadlock in hotkey input open/close
commit: 16a7b5e0e4e3ba9997658b218559fff7ac1ccfb3

--
i.