Re: [PATCH] ASoC: stm32: spdifrx: fix synchronization state check

[Olivier MOYSAN]

Hi Avi,

On 10/11/26 05:54, Avi Weiss wrote:
> The interrupt handler uses a logical AND to check whether SPDIFRX
> was in the SYNC state before clearing errors. Since both SYNC (1)
> and ENABLE (3) are nonzero, this also treats ENABLE as SYNC (and
> any other non-zero value that might be added).
>
> The logical && basically just converts this to check for != 0.
>
> So errors occurring while SPDIFRX is enabled cause the driver
> to retry synch instead of disconnecting the PCM stream.
>
> Fix is to change the logical && to equality (==) and only retry
> when exactly in sync state.
>
> Fixes: 0c93c291321f2 ("ASoC: stm32: spdifrx: retry synchronization in sync state")
> Signed-off-by: Avi Weiss <thnkslprpt@xxxxxxxxx>
> ---
>   sound/soc/stm/stm32_spdifrx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c
> index 0ece547407739..88863dbd05d9b 100644
> --- a/sound/soc/stm/stm32_spdifrx.c
> +++ b/sound/soc/stm/stm32_spdifrx.c
> @@ -720,7 +720,7 @@ static irqreturn_t stm32_spdifrx_isr(int irq, void *devid)
>   
>   	if (err) {
>   		regmap_read(spdifrx->regmap, STM32_SPDIFRX_CR, &cr);
> -		sync_state = FIELD_GET(SPDIFRX_CR_SPDIFEN_MASK, cr) &&
> +		sync_state = FIELD_GET(SPDIFRX_CR_SPDIFEN_MASK, cr) ==
>   			     SPDIFRX_SPDIFEN_SYNC;
>   
>   		/* SPDIFRX is in STATE_STOP. Disable SPDIFRX to clear errors */
>
> base-commit: 611680f6050a66b84e5cc0af33862a83d1f7a200

Reviewed-by: Olivier Moysan <olivier.moysan@xxxxxxxxxxx>

Thanks
Olivier