Re: [PATCH 04/32] s390/bug: Indicate modified PSW in disassembly

[Ilya Leoshkevich]

On 10/12/26 17:29, Heiko Carstens wrote:
> On Mon, Oct 12, 2026 at 05:07:52PM +0200, Ilya Leoshkevich wrote:
> > > -		pr_cont("%s", buffer);
> > > -		ptr = buffer;
> > > -		ptr += sprintf(ptr, "\n          ");
> > > +		pr_cont("%s\n", buffer);
> >
> > Should this really be pr_cont() and not printk()?
> > The KERN_CONT doc says:
> >
> >      only done after a line that had no enclosing \n
> >
> > and the new code prints everything line-by-line.
>
> I guess it doesn't matter too much. The old code worked around that (by
> accident, not intentionally) by printing the new line the beginning.
> Which is most likely also not correct.
> So yes, I can change it to printk().

Thanks! Since it doesn't matter (I didn't read the code to see what the
punishment for ignoring the doc would be), with our without the change:

Reviewed-by: Ilya Leoshkevich <iii@xxxxxxxxxxxxx>