Re: [PATCH net-next V2 5/5] net/mlx5: nodnic: Add health monitoring

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The patch removes the trailing newline from
  drivers/net/ethernet/mellanox/mlx5/nodnic/Makefile.

--

net/mlx5: nodnic: Add health monitoring

This commit adds firmware health monitoring to the nodnic driver. A timer
periodically polls the health buffer in the initialization segment. It
detects fatal sensors, stalls in the health counter, and syndrome changes.
Polling is started from probe and stopped in remove.

> diff --git a/drivers/net/ethernet/mellanox/mlx5/nodnic/Makefile b/drivers/net/ethernet/mellanox/mlx5/nodnic/Makefile
> index 25865d7244d82..1d09edeaf3af8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/nodnic/Makefile
> +++ b/drivers/net/ethernet/mellanox/mlx5/nodnic/Makefile
> @@ -5,4 +5,4 @@
>  
>  obj-$(CONFIG_MLX5_NODNIC) += mlx5_nodnic.o
>  
> -mlx5_nodnic-y := main.o en.o en_cfg.o tx.o rx.o nodnic_pci_vsc.o
> +mlx5_nodnic-y := main.o en.o en_cfg.o tx.o rx.o nodnic_pci_vsc.o health.o
> \ No newline at end of file

[Severity: Low]
This isn't a bug, but the trailing newline at the end of the nodnic
Makefile has been dropped. Before this patch the mlx5_nodnic-y line ended
with a newline. Could it be put back so that checkpatch doesn't warn and
the next change to this file doesn't show an unrelated whitespace hunk?

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261008171821.660739-1-tariqt%40nvidia.com