Re: [PATCH for-7.5 1/5] memcg: move memory.high enforcement out of try_charge_memcg()

From: Shakeel Butt

Date: Mon Oct 12 2026 - 14:10:36 EST


On Mon, Oct 12, 2026 at 02:22:40PM +0100, Harry Yoo wrote:
> On Sat, Oct 10, 2026 at 02:09:53PM -0700, Shakeel Butt wrote:
> > try_charge_memcg() does a lot. It charges the page counters, reclaims
> > when a limit is hit, may call the OOM killer, and at the end it checks
> > and enforces memory.high. Move the memory.high part into a new function,
> > memcg_enforce_high(), so that try_charge_memcg() is shorter and the
> > memory.high code is easier to read and change.
> >
> > The code and its comments move as they are. The only difference is that
> > the new function gets allow_spinning from gfp_mask itself.
> >
> > No functional change.
> > ---
>
> Missing Signed-off-by: ?

Oh I don't know how I missed this.

>
> Otherwise LGTM.
> Reviewed-by: Harry Yoo (Meta) <harry@xxxxxxxxxx>

Thanks for the review.