Re: [PATCH 04/11] gpio: Add Cortina Systems CS75xx GPIO driver

From: Uwe Kleine-König

Date: Mon Oct 12 2026 - 16:33:16 EST


Hello,

On Mon, Oct 12, 2026 at 08:32:59PM +0300, Fil Dunsky wrote:
> +#include <linux/mod_devicetable.h>

Please don't include this file. It contains a plethora of defines for
subsystems not in use here.

> [...]
> +#include <linux/platform_device.h>

You can rely on <linux/platform_device.h> to yield definitions for
of_device_id and so drop <linux/mod_devicetable.h> without a
replacement.

The same applies to patches 6 and 7.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature