Re: [PATCH v2 2/2] iio: proximity: Add driver for Vishay VCNL36829

[Andy Shevchenko]

On Tue, Oct 06, 2026 at 06:09:43PM +0800, Liu Yufei wrote:

> Add an IIO driver for the Vishay VCNL36829 proximity sensor with
> integrated VCSEL, connected over I2C.
> 
> At probe the driver enables the vdd and vddio supplies, waits for the
> sensor to power up, checks the device ID, configures the VCSEL current
> and photodiodes, and turns the proximity engine on. The sensor is put
> back into shutdown when the device is removed.
> 
> The following attributes are exposed:
>   - in_proximity0_raw
>   - in_proximity_integration_time
>   - in_proximity_integration_time_available

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

...

> +static int vcnl36829_write_raw(struct iio_dev *indio_dev,
> +			       struct iio_chan_spec const *chan, int val,
> +			       int val2, long mask)

Please, wrap on a logical boundary:

			       struct iio_chan_spec const *chan,
			       int val, int val2, long mask)

-- 
With Best Regards,
Andy Shevchenko