Re: [PATCH v4] usb: hub: Set proper message when usb_hub_create_port_device() fails

[Andy Shevchenko]

On Mon, Oct 12, 2026 at 11:53:04PM +0300, Andy Shevchenko wrote:
> On Mon, Oct 12, 2026 at 05:27:24PM +0800, Chen-Yu Tsai wrote:

...

> >  		if (ret < 0) {
> >  			dev_err(hub->intfdev,
> >  				"couldn't create port%d device.\n", i + 1);
> > +			message = "couldn't create port device";
> >  			break;
> 
> We can now even use
> 
> 			message = "couldn't create port device";
> 			dev_err(hub->intfdev, "%s %d.\n", message, + 1);

Of course this has to be

			dev_err(hub->intfdev, "%s %d.\n", message, i + 1);

but in any case it's up to you depending on the template used for the rest of
the messages in this function.

> >  		}

-- 
With Best Regards,
Andy Shevchenko