Re: [PATCH v3 00/10] perf symbol: Properly set DSO binary/symtab types

[Namhyung Kim]

On Mon, Oct 12, 2026 at 02:41:27PM -0700, Ian Rogers wrote:
> On Sun, Oct 11, 2026 at 10:26 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > Hello,
> >
> > Currently we have 3 types for a DSO.
> >
> > * binary type: determines where to read binary instruction or data of the
> >   DSO.  Basically used by annotate.  Some (special) DSOs like kallsyms or
> >   JIT may not have the data though.
> >
> > * symtab type: determines where to read symbol tables.  Set when symbols
> >   in the DSO are loaded.
> >
> > * debug info type: determines where to read debug info.  Used by srcline,
> >   DWARF unwinding, data type profiling and so on.  Often debug info is
> >   saved in a separate file.
> >
> > Some DSOs may have the same type for 3 and others can have all different.
> > Previously it generally assumed binary type would be same as symtab type
> > but now I think we should not and only set the binary type as it's used.
> >
> > Also it should make sure that symtab type is set properly after loading
> > symbols in the DSO.
> >
> > Probably this patchset won't make any practical difference in runtime
> > behaviors but I think it's good to track them accurately.
> 
> Except for nits and resolving the remaining Sashiko feedback on patch 6.
> 
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks for your review!

I'll sent v4 with the fixes soon.

Thanks,
Namhyung