Re: [PATCH] firewire: core: use appropriate spinlock variants for transaction-related locks

[Takashi Sakamoto]

On Mon, Oct 12, 2026 at 10:57:39AM +0900, Takashi Sakamoto wrote:
> The spinlocks in the fw_card structure protect transaction-related state
> from concurrent access. They are acquired mostly from process context.
> The exceptions are split_transaction_timeout_callback(), which runs in
> softirq context for the timer wheel, and __fw_send_request(), which may
> also be called from interrupt context.
> 
> Use spin_lock() in split_transaction_timeout_callback() and
> spin_lock_irqsave() in the other functions. The latter preserves and
> restores the caller's interrupt state, as the callers are not guaranteed
> to have interrupts enabled.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> ---
>  drivers/firewire/core-transaction.c | 21 ++-------------------
>  1 file changed, 2 insertions(+), 19 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto