Re: [PATCH net-next v4 1/9] dt-bindings: net: dsa: realtek: add RTL8367S-V
From: netdev-bot+sashiko
Date: Mon Oct 12 2026 - 21:08:35 EST
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit subject names the wrong part.
--
dt-bindings: net: dsa: realtek: add RTL8367S-V
This commit adds RTL8367S-VB (chip ID 0x6642) to the list of models
covered by the realtek,rtl8365mb compatible in the DSA realtek binding.
The chip is identified by its chip ID register, so it does not get a
separate compatible string.
> dt-bindings: net: dsa: realtek: add RTL8367S-V
[Severity: Low]
This isn't a bug, but the subject line seems to be missing the final B.
The commit body and the diff both say RTL8367S-VB:
> The RTL8367S-VB (chip ID 0x6642) is supported by the rtl8365mb driver
> + RTL8367S-VB, RTL8367SB, RTL8370MB, RTL8310SR
The later driver patch in the series, "net: dsa: realtek: rtl8365mb: add
support for RTL8367S-VB", also uses RTL8367S-VB.
Could the subject be changed to "add RTL8367S-VB"?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/38872e6f-1264-4a93-9f81-8212173e909d%40yahoo.com