Re: [PATCH net v2] net: phylink: allow stopping a suspended instance

[Andrew Lunn]

On Mon, Oct 05, 2026 at 01:09:05PM -0600, James Hilliard wrote:
> After a failed MAC resume, a driver must be able to stop phylink without
> resuming it and reconfiguring the failed MAC. This is needed when recovery
> leaves the interface administratively up but detached until a subsequent
> down/up: ndo_stop() must finish the suspended phylink lifetime even though
> the MAC could not be restored. The missing transition was identified by
> code inspection of the stmmac recovery paths.

I don't particularly like this. It feels like a workaround for a
broken MAC. It would be better to fix the MAC so that resume does not
fail.

As far as i know, this it theoretical, only triggered by fault
injection. If we find a real error situation where the MAC cannot be
resumed, then i will consider it. But until then, i prefer to reject
this patch.

     Andrew