Re: [PATCH] ext4: check CAP_SYS_ADMIN in ext4_ioctl_get_tune_sb()
From: Guanglei Zhu
Date: Mon Oct 12 2026 - 22:02:06 EST
I checked the original series (20250916-tune2fs-v2): neither the
commit message of 04a91570ac67 nor the discussion around it says
anything about a permission policy for the GET side - the only
statement is that the ioctls allow parameters to be changed while
the file system is mounted, without needing write access to the
block device.
You are probably right that reading these parameters is not
sensitive on its own: most of them are already visible through
/proc/mounts or statfs(), and the superblock is readable by anyone
with read access to the block device. The argument of my patch was
the asymmetry with the SET side rather than an actual leak.
I'm happy to drop this patch if Ted confirms that the missing check
was deliberate.