Re: [PATCH 6.1.y] wifi: cfg80211: release locks on error in cfg80211_wext_siwgenie()

[Greg KH]

On Mon, Oct 12, 2026 at 11:42:46PM +0800, Wentao Guan wrote:
> This error path returns while wdev_lock() is still held, so one
> malformed IE request can permanently block later operations on this
> wiphy. Route the error through out to release the lock.
> 
> Reported-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/93db0eae-f479-4343-a126-59987ae0dc22@xxxxxxxxxx/
> Fixes: 8b921a899346 ("wifi: cfg80211: validate IEs in cfg80211_wext_siwgenie()")
> Signed-off-by: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
> ---
>  net/wireless/wext-sme.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/net/wireless/wext-sme.c b/net/wireless/wext-sme.c
> index be121fa36c514..ba6d8827f64b3 100644
> --- a/net/wireless/wext-sme.c
> +++ b/net/wireless/wext-sme.c
> @@ -352,8 +352,10 @@ int cfg80211_wext_siwgenie(struct net_device *dev,
>  			/* nothing */
>  		}
>  
> -		if (!for_each_element_completed(elem, extra, ie_len))
> -			return -EINVAL;
> +		if (!for_each_element_completed(elem, extra, ie_len)) {
> +			err = -EINVAL;
> +			goto out;
> +		}
>  
>  		ie = kmemdup(extra, ie_len, GFP_KERNEL);
>  		if (!ie) {
> -- 
> 2.39.5
> 
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>