Re: [PATCH 1/2] dt-bindings: crypto: Adjust Shikra compatible hierarchy
From: Krzysztof Kozlowski
Date: Tue Oct 13 2026 - 02:45:08 EST
On Tue, Oct 06, 2026 at 04:44:03PM +0530, Kuldeep Singh wrote:
> Shikra reuses the same QCE integration as Agatti and should follow the
`git grep Agatti` gives zero.
> corresponding binding requirements too.
>
> Move the Shikra compatible to the appropriate binding hierarchy
> (matching qcom,qcm2290-qce) to reflect the underlying hardware
> description.
You do not change any binding hierarchy. You are changing fallback
compatible which is ABI break without any reason.
>
> Fixes: 45834ff95a6f ("dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@xxxxxxxxxxxxxxxx>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
Drop, that's v1, so this likely did not happen. Anyway, your SoB is
supposed to be last.
Best regards,
Krzysztof