Re: [PATCH] staging: iio: addac: adt7316: use dev_err_probe() for ldac GPIO
From: Joshua Crofts
Date: Tue Oct 13 2026 - 03:54:45 EST
On Tue, 13 Oct 2026 00:28:25 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> On Sun, Oct 11, 2026 at 07:56:22PM +0100, Raffaele Tranfaglia via B4 Relay wrote:
>
> > Use dev_err_probe() when requesting the ldac GPIO fails. This
> > avoids logging an error when the GPIO controller is not ready yet
> > and the request returns -EPROBE_DEFER, and records the deferral
> > reason. It also simplifies the error path.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>
> Although not sure if we need a Fixes tag as it might be an annoying (but quite
> rare) case of flooding in the dmesg.
AFAIC this is a cleanup rather than a fix. dev_err_probe() conversions
don't add Fixes tags.
--
Kind regards,
Joshua Crofts