Re: [PATCH v2] gpio: amdptpci: add support for AMD PT PCI controller

[Markus Elfring]

> This commit implements the new gpio-amdptpci driver to support the
…

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n94


> Signed-off-by: Szuying Chen <Chloe_Chen@xxxxxxxxxxxxxx>
> Co-authored-by: YD Tseng <Yd_Tseng@xxxxxxxxxxxxxx>

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n502


> v1->v2:
…
> ---
…
>  drivers/gpio/gpio-amdptpci.c | 891 +++++++++++++++++++++++++++++++++++

Please move patch version descriptions behind the marker line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3-rc7#n793


…
> +++ b/drivers/gpio/gpio-amdptpci.c
> @@ -0,0 +1,891 @@
…
> +static int pt27_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
> +{
…
> +	raw_spin_lock_irqsave(&chip->lock, flags);
> +	val = pt27_rd32(chip, PT27_REG_DIR);
> +	raw_spin_unlock_irqrestore(&chip->lock, flags);
…

Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&chip->lock);”?
https://elixir.bootlin.com/linux/v7.3-rc6/source/include/linux/spinlock.h#L594-L597

Regards,
Markus