Re: [PATCH v4 17/20] platform/x86/intel/tpmi: Use scnprintf() to build the debugfs names
From: Andy Shevchenko
Date: Tue Oct 13 2026 - 05:37:24 EST
On Tue, Oct 13, 2026 at 11:42:00AM +0300, Ilpo Järvinen wrote:
> On Mon, 12 Oct 2026, Andy Shevchenko wrote:
> > On Tue, Oct 06, 2026 at 11:30:34AM -0700, Kuppuswamy Sathyanarayanan wrote:
> > > snprintf() is on its way out in favour of scnprintf(). Neither of the two
> > > callers in tpmi_dbgfs_register() looks at the return value, so the
> > > difference in what the two return does not matter here.
> >
> > I believe I asked it already: Why do we care? Do you get any compilation
> > warning (assuming `make W=1`)?
>
> I do care that we've two functions for essentially the same thing and
> would prefer to have just one that remains (and obviously that would be
> the c variant).
I see, thanks for the hint, but it's not clear from the commit message.
--
With Best Regards,
Andy Shevchenko