Re: [PATCH net-next v8 2/7] net: pse-pd: fire lifecycle events on controller register/unregister

From: Kory Maincent

Date: Tue Oct 13 2026 - 05:52:46 EST


> Hook the pse_controller_notifier chain so that pse_controller_register()
> fires PSE_REGISTERED after the controller has been added to
> pse_controller_list (i.e. is now resolvable by of_pse_control_get()),
> and pse_controller_unregister() fires PSE_UNREGISTERED once it has been

Can you update the patch message and the comments to make them human
readable. We want to have mainly the why explained in the commit message.
And if you use comment please make them concise.
I know you have faced painful sashiko reviews that always ask for the
same change but it was the beggining of the kernel AI reviews, I hope this
should be better now.

On the code part, I would prefer having the cleanup reordering on a
separate patch than the implementation of the two notifier call.

--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com