Re: [PATCH] soc: qcom: pmic_glink_altmode: acknowledge notifications on undescribed ports

From: Konrad Dybcio

Date: Tue Oct 13 2026 - 06:50:03 EST


On 9/30/26 1:16 PM, Rahul Pon wrote:
> The driver enables port notifications from the firmware (ALTMODE_PAN_EN)
> for every port, but only acknowledges them (ALTMODE_PAN_ACK) from the
> worker of a port that has a connector node. A notification for any other
> port is logged at debug level and dropped without an acknowledgment.
>
> On an HP OmniBook 5 (Snapdragon X2, Mahua) whose device tree does not
> yet describe the USB-C connectors, the firmware kept charging on the
> connector that was plugged in, but once a notification had gone
> unacknowledged (on unplug), its UCSI connector status reported no
> connection on either port through repeated replugs, and no charging
> session started again. The firmware also reports more UCSI connectors
> than a board may describe to this driver (here a third, USB Standard-A,
> port).

Please fix your DT instead, all you need is to copy-paste some
boilerplate.

Konrad