Re: [PATCH net-next v11 3/6] net: add a generation counter for dev->mc changes

From: Yuyang Huang

Date: Tue Oct 13 2026 - 06:50:28 EST


> - [Low] The commit message misdescribes the precedent it copies.

Looks like a nit, will adjust it if need new revision.

> - [Low] The patch adds an 8-byte 'struct net_device *mc_dev' to every
> struct netdev_hw_addr_list (include/linux/netdevice.h:253), but only…

It seems to me this issue by itself doesn't deserve a revision. Will
fix it if new revision is required.

> - [Low] __hw_addr_changed() (net/core/dev_addr_lists.c:22-26) reads the
> device netns with plain dev_net(list->mc_dev).

This was raised on earlier versions. Every dev->mc writer already
reads dev_net() under only the address lock, so this adds no new race.