Re: [PATCH v1 1/3] dt-bindings: usb: dwc3: Add JHB100 device controller PHY adapter

From: Minda Chen

Date: Tue Oct 13 2026 - 07:48:56 EST




>
> On Thu, Sep 24, 2026 at 04:03:37AM +0000, Minda Chen wrote:
> > >
> > > On Fri, Sep 18, 2026 at 03:11:01PM +0800, Minda Chen wrote:
> > > > Add dt-binding of JHB100 server host field USB device controller
> > > > PHY adapter register IO region and its regs-name.
> > >
> > > I don't understand the rationale here or the other binding patch.
> > > Why is it not always 2 regs? Either the device has 2 or it has 1,
> > > there shouldn't be variability unless there's more than one instance
> > > and the dfferent instances have different numbers?
> > >
> > > Cheers,
> > > Conor.
> > >
> > Thanks for reviewing. The virtual device controller do not contain PHY
>
> I don't know what a "virtual device controller" is, or how it relates to usb3. I'm a
> binding reviewer, not usb, so you'll need to explain this more clearly.
>
Okay

> > but need to add PHY adapter setting(self-develop by StarFive). So have 2 regs.
> > Previous is BMC USB module do not contain it. But if PHY adapter be
> > moved
>
> Are you trying to say that the jhb100 has two different usb3 controllers on it, one
> of which has extra logic implemented by StarFive?
>
Thanks,I will add this to commit message in next version.

> > to PHY related driver can remove this . But Thinh still no review the patch3.
> >
> > > >
> > > > Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> > > > ---
> > > > .../devicetree/bindings/usb/starfive,jhb100-dwc3.yaml | 11
> > > > ++++++++++-
> > > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.yaml
> > > > b/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.yaml
> > > > index fbabe99e9d5c..b2fd98c06ba0 100644
> > > > ---
> > > > a/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.yaml
> > > > +++ b/Documentation/devicetree/bindings/usb/starfive,jhb100-dwc3.y
> > > > +++ aml
> > > > @@ -20,7 +20,16 @@ properties:
> > > > const: starfive,jhb100-dwc3
> > > >
> > > > reg:
> > > > - maxItems: 1
> > > > + minItems: 1
> > > > + items:
> > > > + - description: Core DWC3 region
> > > > + - description: DWC3 device controller adapter region
> > > > +
> > > > + reg-names:
> > > > + minItems: 1
> > > > + items:
> > > > + - const: core
> > > > + - const: adapter
> > > >
> > > > interrupts:
> > > > maxItems: 1
> > > > --
> > > > 2.17.1
> > > >