Re: [PATCH v6 3/3] ARM: dts: renesas: r9a06g032: add EDAC node

[Paul Louvel]

Hi Geert,

On Tue Oct 13, 2026 at 1:41 PM CEST, Geert Uytterhoeven wrote:
> Hi Paul,
>
> On Tue, 13 Oct 2026 at 12:45, Paul Louvel <paul.louvel@xxxxxxxxxxx> wrote:
>> Add EDAC node to the SoC base device tree file.
>>
>> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Paul Louvel (Schneider Electric) <paul.louvel@xxxxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/arch/arm/boot/dts/renesas/r9a06g032.dtsi
>> +++ b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
>> @@ -164,6 +164,15 @@ dmamux: dma-router@a0 {
>>                         };
>>                 };
>>
>> +               edac: memory-controller@4000d000 {
>> +                       compatible = "renesas,r9a06g032-ddr-edac", "cdns,ddr-edac";
>> +                       reg = <0x4000d000 0x1000>;
>> +                       interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
>> +                       clocks = <&sysctrl R9A06G032_CLK_DDRC>, <&sysctrl R9A06G032_HCLK_DDRC>;
>> +                       clock-names = "ddrc", "pclk";
>> +                       status = "disabled";
>
> Should this node be enabled by default, or am I too naive?

The bootloader will be responsible to initialize the DDR controller and enable
ECC if specified. On this specific platform (r9a06g032), ECC is disabled by
default.
Enabling the ECC require a specific property to be present under the controller
node in U-Boot. I think it make sense to keep it by default disabled.

>
>> +               };
>> +
>>                 udc: usb@4001e000 {
>>                         compatible = "renesas,r9a06g032-usbf", "renesas,rzn1-usbf";
>>                         reg = <0x4001e000 0x2000>;
>>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds





-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com