Re: [PATCH 3/6] iio: adc: ltc2497: add LTC2493 internal temperature channel
From: Nuno Sá
Date: Tue Oct 13 2026 - 11:11:10 EST
On Fri, 09 Oct 2026 11:43:36 +0300, Andrei Stancovici <andrei.stancovici@xxxxxxxxxx> wrote:
> diff --git a/drivers/iio/adc/ltc2497-core.c b/drivers/iio/adc/ltc2497-core.c
> index 96b365efd1e9..87eade46beb5 100644
> --- a/drivers/iio/adc/ltc2497-core.c
> +++ b/drivers/iio/adc/ltc2497-core.c
> @@ -396,7 +396,7 @@ int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev)
> indio_dev->channels = ltc2497core_channel;
> indio_dev->num_channels = ARRAY_SIZE(ltc2497core_channel);
> }
> - /* Only the ltc2499 has a temperature channel; it is the last entry. */
> + /* Temperature is the last channel entry; trim it for parts without the sensor. */
Hmm. In the last patch you added the above just to change it in the next
patch? Not seeing a reason why the generic comment cannot be added in
the previous. But I'll go even one step further. I would remove it, the
code is very self explanatory to me :)
(maybe Jonathan can actually drop it when applying)
--
Nuno Sá <nuno.sa@xxxxxxxxxx>