Re: [PATCH] tracing: use assign_bit() where applicable

[Steven Rostedt]

Sorry for the way late reply. I stopped being an upstream maintainer while
traveling. I'm just catching up now.

On Mon, 21 Sep 2026 14:31:19 +0800
Peng Fan <peng.fan@xxxxxxxxxxx> wrote:

> On Sun, Sep 20, 2026 at 07:21:51AM -0400, Steven Rostedt wrote:
> >On Sun, 20 Sep 2026 10:28:10 +0800
> >"Peng Fan (OSS)" <peng.fan@xxxxxxxxxxx> wrote:
> >  
> >> From: Peng Fan <peng.fan@xxxxxxx>
> >> 
> >> Convert open-coded if/else with set_bit/clear_bit the assign_bit API.
> >> 
> >> Done with Coccinelle semantic patch:
> >>  /**
> >> @@ -1673,10 +1670,8 @@ event_enable_trigger(struct event_trigger_data *data,
> >>  {
> >>  	struct enable_trigger_data *enable_data = data->private_data;
> >>  
> >> -	if (enable_data->enable)
> >> -		clear_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &enable_data->file->flags);
> >> -	else
> >> -		set_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &enable_data->file->flags);
> >> +	assign_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &enable_data->file->flags,
> >> +		   !enable_data->enable);  
> >
> >Ditto.  
> 
> This will exceeds 100 columns. Should I keep as it is using two lines?
> 
> WARNING: line length of 101 exceeds 100 columns
> #116: FILE: kernel/trace/trace_events_trigger.c:1673:
> +       assign_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &enable_data->file->flags, !enable_data->enable);
> 

Yeah, if it breaks the 100 characters, then you can do a line break.

Thanks,

-- Steve