Re: [PATCH 03/15] yunsilicon: add the command queue

[Leon Romanovsky]

On Tue, Oct 13, 2026 at 11:11:17AM +0800, Junxian Huang wrote:
> 
> 
> On 2026/10/12 19:43, Xin Tian wrote:
> > Add the command queue that is shared by the ethernet and RDMA functions:
> > the request/response rings, the command work handling and the device
> > initialisation sequence that queries the HCA capabilities, the GUID and
> > the message opcode table.
> > 
> > Signed-off-by: Xin Tian <tianx@xxxxxxxxxxxxxx>
> > ---
> >  .../net/ethernet/yunsilicon/xsc/pci/Makefile  |    2 +-
> >  .../net/ethernet/yunsilicon/xsc/pci/cmdq.c    | 1247 +++++++++++++++++
> >  drivers/net/ethernet/yunsilicon/xsc/pci/hw.c  |  310 ++++
> >  drivers/net/ethernet/yunsilicon/xsc/pci/hw.h  |   18 +
> >  .../net/ethernet/yunsilicon/xsc/pci/main.c    |   55 +
> >  5 files changed, 1631 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c
> >  create mode 100644 drivers/net/ethernet/yunsilicon/xsc/pci/hw.c
> >  create mode 100644 drivers/net/ethernet/yunsilicon/xsc/pci/hw.h
> > 
> > diff --git a/drivers/net/ethernet/yunsilicon/xsc/pci/Makefile b/drivers/net/ethernet/yunsilicon/xsc/pci/Makefile
> > index 81b65232e..656cdffa1 100644
> > --- a/drivers/net/ethernet/yunsilicon/xsc/pci/Makefile
> > +++ b/drivers/net/ethernet/yunsilicon/xsc/pci/Makefile
> > @@ -6,4 +6,4 @@ ccflags-y += -I$(srctree)/drivers/net/ethernet/yunsilicon/xsc
> >  
> >  obj-$(CONFIG_YUNSILICON_XSC_PCI) += xsc_pci.o
> >  
> > -xsc_pci-y := main.o hal/andes_impl.o
> > +xsc_pci-y := main.o cmdq.o hw.o hal/andes_impl.o
> > diff --git a/drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c b/drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c
> > new file mode 100644
> > index 000000000..48832b26d
> > --- /dev/null
> > +++ b/drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c
> > @@ -0,0 +1,1247 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2021-2026, Shanghai Yunsilicon Technology Co., Ltd.
> > + * All rights reserved.
> > + * Copyright (c) 2013-2016, Mellanox Technologies. All rights reserved.
> 
> Why Mellanox?

This is how new RDMA drivers are born :)

Thanks