Re: [PATCH] printk: fix kernel-doc name for nbcon_write_context_is_braille

From: John Ogness

Date: Tue Oct 13 2026 - 12:29:23 EST


On 2026-10-06, Muhammad Mahdi Amirpour <ampr.mhd@xxxxxxxxx> wrote:
>

Do we allow empty commit messages? The patch title says it all, so I
guess it is ok.

Now that Linus has pulled the Braille fix, please add:

Fixes: c83e3d291243 ("braille: nbcon: Allow to use a serial console with NBCON API as Braille console")

> Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@xxxxxxxxx>

...

> diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
> index fb1b37741..6f9735f4b 100644
> --- a/kernel/printk/nbcon.c
> +++ b/kernel/printk/nbcon.c
> @@ -2005,7 +2005,7 @@ void nbcon_kdb_release(struct nbcon_write_context *wctxt)
> }
>
> /**
> - * nbcon_is_braille - Checks whether the nbcon write context is using Braille console
> + * nbcon_write_context_is_braille - Checks whether the nbcon write context is using Braille console

Please wrap the comment to 80 columns. You can see
nbcon_device_try_acquire() for an example of a wrapping short
kerneldoc description.

John Ogness