Re: [PATCH v6 1/2] dt-bindings: iio: light: add as7343

[Chang Yu]

On Tue, Oct 13, 2026 at 02:36:39PM +0200, Joshua Crofts wrote:
> On Tue, 13 Oct 2026 19:56:38 +0800
> Chang Yu <marcus.yu.56@xxxxxxxxx> wrote:
> 
> > Add binding for AMS AS7343 which is a 14-channel multi-spectral sensor
> > with i2c address of 0x39.
> > 
> > The GPIO pin is not described because the datasheet does not document
> > how to use it for hardware synchronization at all. The GPIO register
> > also has no mode-select bit to isolate the pin from the chip's
> > internal control logic. Exposing it as a generic GPIO could result
> > in kernel writes being overwritten by internal logic.
> > 
> > Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel-Multi-Spectral-Sensor.pdf
> > Signed-off-by: Chang Yu <marcus.yu.56@xxxxxxxxx>
> > ---
> > Changes in v6:
> >  - Add a ref to leds/common.yaml for the LDR pin.
> > 
> > Changes in v5:
> >  - Remove the GPIO pin.
> > 
> > Changes in v4:
> >  - Fix led-max-microamp property name.
> > 
> > Changes in v3:
> >  - Add missing include for gpio.
> >  - Expand GPIO descrption to include hardware synchronization.
> >  - Use led-max-microamp instead of led-current-microamp for the LDR pin.
> > 
> > Changes in v2:
> >  - Add the LDR, the interrupt pin, and the GPIO pin to the bindings.
> >  - Fix node name and unit address mismatch.
> >  - Include MAINTAINERS changes.
> > 
> >  .../bindings/iio/light/ams,as7343.yaml        | 66 +++++++++++++++++++
> >  MAINTAINERS                                   |  6 ++
> >  2 files changed, 72 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/light/ams,as7343.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml
> > new file mode 100644
> > index 000000000000..7fb10b0d4843
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/light/ams,as7343.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: AMS AS7343 14-Channel Multi-Spectral Sensor
> > +
> > +maintainers:
> > +  - Chang Yu <marcus.yu.56@xxxxxxxxx>
> > +
> > +description: |
> > +  The AMS AS7343 is a 14-channel multi-spectral sensor with i2c address of 0x39.
> > +  https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel-Multi-Spectral-Sensor.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - ams,as7343
> > +
> > +  reg:
> > +    description:
> > +      I2C address of the device (0x39).
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    description:
> > +      Open drain output active low interrupt pin.
> > +    maxItems: 1
> > +
> > +  vdd-supply: true
> > +
> > +  led-max-microamp:
> > +    description:
> > +      The driver current for the external LED connected to the LDR pin.
> > +    minimum: 4000
> > +    maximum: 258000
> > +    multipleOf: 2000
> > +    default: 12000
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - vdd-supply
> > +
> > +additionalProperties: false
> 
> Should be unevaluatedProperties as you're using $refs in the binding,
> but Jonathan could tweak that when applying.
> 
There was a discussion about this back in v2 in which Conor was suggesting
keeping additionalProperties: false if I recall. I don't know the exact
pros vs cons so I'll defer to the experts here.