Re: [PATCH v6 2/2] iio: light: add AS7343 multi-spectral sensor driver

[Andy Shevchenko]

On Tue, Oct 13, 2026 at 02:35:21PM +0200, Joshua Crofts wrote:
> On Tue, 13 Oct 2026 19:56:39 +0800
> Chang Yu <marcus.yu.56@xxxxxxxxx> wrote:
> 
> > Add a driver for the AMS AS7343 14-channel multi-spectral sensor.
> > 
> > The AS7343 is a 14-channel spectral sensor featuring 11 visible
> > channels, 1 near-infrared channel, 1 clear channel (VIS), and 1
> > flicker detection channel.
> > 
> > The driver exposes 12 spectral channels (11 visible light and 1
> > near-infrared) via sysfs. Runtime PM is implemented to stop
> > measurements when the device is suspended or torn down. Power is
> > never cut (PON=1 always) to preserve register values.
> > 
> > Future patches will add configurable gain and integration time,
> > interrupt support, buffered reads, VIS channel, and flicker
> > detection.
> > 
> > Datasheet: https://look.ams-osram.com/m/5f2d27fff9a874d2/original/AS7343-14-Channel-Multi-Spectral-Sensor.pdf
> > Signed-off-by: Chang Yu <marcus.yu.56@xxxxxxxxx>
> > ---
> 
> I think this is ready to be applied.

I agree. I have a few nit-picks (easy to address), after that feel also free to
add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko